[K2] Fix missing @constructor documentation for primary constructors
#3499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@constructor documentation for primary constructors@constructor documentation for primary constructors
This was
linked to
issues
Feb 18, 2024
IgnatBeresnev
approved these changes
Feb 22, 2024
| @@ -80,8 +77,26 @@ internal data class KDocContent( | |||
| ) | |||
|
|
|||
| internal fun KtAnalysisSession.findKDoc(symbol: KtSymbol): KDocContent? { | |||
| // Dokka's HACK: primary constructors can have the [KtSymbolOrigin.SOURCE_MEMBER_GENERATED] origin | |||
There was a problem hiding this comment.
Could you please expand on what it means in the comment? I understand that it might have the SOURCE_MEMBER_GENERATED, but I don't understand what it implies, i.e what sorts of problems it causes or why it's different / needs special handling / what the end result is?
1cfd012 to
fd539a7
Compare
fd539a7 to
95f7125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3452
#3379 (the tests in #3500)