-
Notifications
You must be signed in to change notification settings - Fork 452
Clean up GitHub workflows #2951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem like we need to validate the wrapper unless it's been changed.
- Extracted it into a separate file so that it can be run with a
paths
filter. - Additionally running it on every commit in master in case someone with write access pushes it without a PR or does something funny to it indirectly.
.github/workflows/rebase.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think anyone needs it? I noticed it a while ago and thought it was useful, but I still never used it..
We have quite a number of actions that do nothing or are not very helpful, yet they waste time and have a possibility of randomly failing for uncontrollable reasons, not to say they make it impossible to understand which checks are important and which aren't. This PR addresses that problem, along with some minor improvements like naming.
The minimal number of jobs per PR went down from 29 to just 7
Unit test changes
We currently (as in before this PR) run unit tests with a matrix of linux/windows and java 8/11/17. Running the tests on both windows and linux is helpful, it has caught significant problems before.
However, running under different Java versions for every single commit is not that helpful. On the contrary, Java 17 tends to be very flaky, so we have to restart it all the time.
I've changed it so that we run:
Long and thorough tests can be triggered manually for a specific branch, so we should have the possibility of validating big changes in advance (i.e if we see that it might break java 8 or 17).
Later on it'd be nice to randomize some aspects of the tests using something like github-actions-random-matrix. We'd be able to run random Java versions for PR tests, or shuffle platforms. This way, it'll still be quick, yet it should cover more cases overall as there are typically multiple commits in a PR.
Common changes
examples/**
directory was touched. Otherwise, they are using a stable version of Dokka and no other changes in code should affect them.I'll leave more detailed/context comments for individual changes/files