Move plugin version management to buildSrc/build.gradle.kts #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floscher
commented
Aug 17, 2020
Comment on lines
+17
to
37
| repositories { | ||
| exclusiveContent { | ||
| forRepository { | ||
| gradlePluginPortal() | ||
| } | ||
| filter { | ||
| pluginVersions.forEach { includeVersion(it.group!!, it.name, it.version!!) } | ||
| } | ||
| } | ||
| jcenter() | ||
| maven("https://dl.bintray.com/kotlin/kotlin-eap/") { | ||
| content { | ||
| includeGroupByRegex("^org\\.jetbrains\\.(anko|dokka|kotlin|kotlinx)(\\..+)?$") | ||
| } | ||
| } | ||
| maven("https://dl.bintray.com/kotlin/kotlin-dev/") { | ||
| content { | ||
| includeGroupByRegex("^org\\.jetbrains\\.(anko|dokka|intellij|kotlin|kotlinx)(\\..+)?$") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Here, I added an exclusiveContent rule for the plugins to only be taken from gradlePluginPortal() and some regex rules for kotlin-eap and kotlin-dev to avoid unnecessary requests to those repos.
This could be replaced by some more elaborate logic in buildSrc/src/main/kotlin that could then be reused in any other Gradle buildscript in the project (except buildSrc/buildSrc/build.gradle.kts).
de135ce to
4397c96
Compare
|
Thank you for the effort! Sorry it hasn't been addressed properly. I'll close this PR in favour of #2704, there's quite a bit of refactoring, including the move of plugin version management to buildSrc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While researching a similar issue, I recently came across gradle/gradle#11090 (comment) (cc @sellmair ) about how the
pluginManagement{}block insettings.gradle.ktscan't access logic defined inbuildSrc.So I thought I'd share how I'm trying to solve that problem in some of my projects. Just in case this could be useful for this project, too.
There are two parts to this solution:
There is a second
buildSrcproject inside the existingbuildSrcproject. It only contains a shortbuild.gradle.ktsscript and just compiles the sources of the firstbuildSrcproject one additional time, so those classes are on the classpath ofbuildSrc/build.gradle.kts.At the moment this is not utilized in this pull request, but you could then add build logic to
buildSrc/src/main/kotlinthat can be reused in the buildscript ofbuildSrcfor e.g. plugin version management.This may sound like a hack, but in my experience this works pretty reliably.
The plugin versions are defined in
buildSrc/build.gradle.ktsasdependencies.implementation("‹…›")instead of using thepluginManagement{}block insettings.gradle.kts.This gets rid of version inconsistencies like
dokka/settings.gradle.kts
Line 31 in b19ce3c
dokka/buildSrc/build.gradle.kts
Line 11 in b19ce3c
Also subprojects can then no longer declare conflicting plugin versions like
dokka/settings.gradle.kts
Line 32 in b19ce3c
dokka/runners/gradle-plugin/build.gradle.kts
Line 6 in b19ce3c
Plugin request for plugin already on the classpath must not include a version.