fix: file validation with lookup tags #1669
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/validate-partials #1669 +/- ##
=========================================================
- Coverage 28.13% 28.11% -0.03%
=========================================================
Files 67 67
Lines 6963 6969 +6
=========================================================
Hits 1959 1959
- Misses 4862 4868 +6
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e4f7c8c to
448c403
Compare
448c403 to
20c7a74
Compare
tests/integration/validate_test.go
Outdated
| err := validate(tc.mode, validateOpts...) | ||
| if tc.errorExpected { | ||
| require.Error(t, err) | ||
| if tc.errorString != "" { |
There was a problem hiding this comment.
Is this if condition required? 👀
There was a problem hiding this comment.
I had added it to avoid panics for future, but since this is a test, we can let it go. Updated the code.
| { | ||
| name: "validate partials", | ||
| stateFile: "testdata/validate/001-partials/partials.yaml", | ||
| additionalArgs: []string{"--online-entities-list=Partials"}, |
There was a problem hiding this comment.
Is the arg relevant for offline validation - since we are anyway printing an error message
There was a problem hiding this comment.
Approving the PR, this can be fixed on main PR if needed.
* fix: fixed validate command for partials and partial lookups * tests: fix err string * fix: file validation with lookup tags (#1669) * fix: file validation with lookup tags * chore: removed err string condition * tests: removed unnecessary flag
For #1668