ci: removed docker login from validate workflow #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
=======================================
Coverage 28.19% 28.19%
=======================================
Files 67 67
Lines 6949 6949
=======================================
Hits 1959 1959
Misses 4848 4848
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Docker Hub login step from the validate workflow as it is unnecessary for public repositories.
- Removed the Docker Hub login step.
- Updated the workflow file to reflect that no authentication is required for the public Docker images.
harshadixit12
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kong/kong-gateway-devandkong/kong-devare public repos and thus don't require docker logins.This worked till now but I believe the docker user we were using was getting access denied with recent images.
For now, removing the docker login as it isn't not required.
Confirmed here: https://kongstrong.slack.com/archives/C027PKSNBC5/p1750151682471579?thread_ts=1750148184.011979&cid=C027PKSNBC5