Skip to content

feat: added lookups for partials #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Conversation

Prashansa-K
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 28.19%. Comparing base (1bac304) to head (7d40211).

Files with missing lines Patch % Lines
cmd/common.go 0.00% 25 Missing ⚠️
tests/integration/test_utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1653      +/-   ##
==========================================
- Coverage   28.30%   28.19%   -0.11%     
==========================================
  Files          67       67              
  Lines        6922     6948      +26     
==========================================
  Hits         1959     1959              
- Misses       4821     4847      +26     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Prashansa-K Prashansa-K force-pushed the feat/lookup-tags-partials branch from 5d07c50 to 7d40211 Compare June 16, 2025 03:25
reconcilerUtils.RemoveDuplicates(&targetContent.Info.LookUpSelectorTags.Partials)
sort.Strings(targetContent.Info.LookUpSelectorTags.Partials)
return targetContent.Info.LookUpSelectorTags.Partials, nil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - extra line

send_timeout: 2004
tags:
- redis-partials

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra line

@Prashansa-K Prashansa-K merged commit 8418b7d into main Jun 16, 2025
24 checks passed
@Prashansa-K Prashansa-K deleted the feat/lookup-tags-partials branch June 16, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants