feat: adding support for keys keysets in deck #1645
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
- Coverage 28.34% 28.30% -0.05%
==========================================
Files 67 67
Lines 6912 6922 +10
==========================================
Hits 1959 1959
- Misses 4811 4821 +10
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
In touch with Konnect team to clarify the difference in ordering and input validation: https://kongstrong.slack.com/archives/CQK8J4VN3/p1748328003725309 |
| @@ -527,3 +527,73 @@ func Test_Dump_ConsumerGroupPlugin_PolicyOverrides(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Lets add the test scope comment?
There was a problem hiding this comment.
I have added the scope in both of the tests. Not sure why the diff is not catching it.
You can check the change while viewing the entire file though:
deck/tests/integration/dump_test.go
Line 533 in 35b8511
| @@ -8290,3 +8290,149 @@ func Test_Sync_Scoped_Plugins_Check_Conflicts(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| // test scope: | |||
| // | |||
There was a problem hiding this comment.
Not extra. We leave one in the middle before adding the scope.
|
couple of nitpicks, but otherwise lgtm |
No description provided.