tests: add tests for custom entity partial apply #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
055ee10 to
37d8598
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
=======================================
Coverage 29.03% 29.03%
=======================================
Files 67 67
Lines 6912 6912
=======================================
Hits 2007 2007
Misses 4755 4755
Partials 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harshadixit12
commented
May 7, 2025
go.mod
Outdated
| @@ -13,14 +13,14 @@ require ( | |||
| github.com/fatih/color v1.18.0 | |||
| github.com/google/go-cmp v0.7.0 | |||
| github.com/kong/go-apiops v0.1.42 | |||
| github.com/kong/go-database-reconciler v1.22.5 | |||
| github.com/kong/go-database-reconciler v1.22.6-0.20250507085334-9b3909e50a57 | |||
There was a problem hiding this comment.
To be updated after gdr is released
37d8598 to
667df51
Compare
5 tasks
Prashansa-K
reviewed
May 9, 2025
tests/integration/apply_test.go
Outdated
| // - konnect | ||
| func Test_Apply_Custom_Entities_Konnect(t *testing.T) { | ||
| t.Setenv("DECK_KONNECT_CONTROL_PLANE_NAME", "default") | ||
| runWhen(t, "konnect", "") |
There was a problem hiding this comment.
We can do runWhenEnterpriseOrKonnect in the above test. This one shouldn't be required then.
667df51 to
b1dcfba
Compare
Prashansa-K
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we are bumping Go database reconciler and adding integrations tests to run
gateway applyfor custom entities.PR on GDR: Kong/go-database-reconciler#267
Issues resolved
#1568
Testing