Skip to content

ci: corrected test pipelines #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

ci: corrected test pipelines #1606

merged 4 commits into from
Apr 23, 2025

Conversation

Prashansa-K
Copy link
Contributor

  • added docker login in validate workflow to account for access denied errors while doing docker pull.
  • removed wasm variables from docker builds.
  • skipped filter-chain tests for now.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.91%. Comparing base (c82f467) to head (69d4f25).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1606   +/-   ##
=======================================
  Coverage   28.91%   28.91%           
=======================================
  Files          65       65           
  Lines        6765     6765           
=======================================
  Hits         1956     1956           
  Misses       4667     4667           
  Partials      142      142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Prashansa-K
Copy link
Contributor Author

Validated via: https://github.com/Kong/deck/actions/runs/14589120522

@harshadixit12
Copy link
Contributor

Changes LGTM, could you please elaborate more on the why for these changes?

@Prashansa-K
Copy link
Contributor Author

Underlying module for wasm stuff is disabled in the gateway: https://github.com/Kong/kong-ee/pull/11963
I have confirmed from Michael Martin (the linked PR's author) that we are supposed to remove the WASM related environment variables, so as to not cause build failures while setting up Kong in CI.

@Prashansa-K Prashansa-K force-pushed the ci/corrected-test-pipelines branch from 368a75c to a856207 Compare April 23, 2025 06:44
@Prashansa-K Prashansa-K enabled auto-merge (squash) April 23, 2025 06:50
@Prashansa-K Prashansa-K merged commit 75480d6 into main Apr 23, 2025
24 checks passed
@Prashansa-K Prashansa-K deleted the ci/corrected-test-pipelines branch April 23, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshadixit12 harshadixit12 harshadixit12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Prashansa-K @codecov-commenter @harshadixit12