Skip to content

refactor: refactor necessary for migration utility #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

Prashansa-K
Copy link
Contributor

Required for: #1554

This PR structures the convert command utilities in their specific files.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.62025% with 24 lines in your changes missing coverage. Please review.

Project coverage is 28.97%. Comparing base (b20e10e) to head (44a28ec).

Files with missing lines Patch % Lines
convert/pluginUpdates.go 61.11% 14 Missing and 7 partials ⚠️
convert/utils.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
+ Coverage   28.91%   28.97%   +0.05%     
==========================================
  Files          62       65       +3     
  Lines        6765     6765              
==========================================
+ Hits         1956     1960       +4     
+ Misses       4667     4664       -3     
+ Partials      142      141       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshadixit12
Copy link
Contributor

@Prashansa-K any reason for refactor apart from readability and better organization? since they are still in same package

@Prashansa-K Prashansa-K merged commit 5953c1f into main Apr 22, 2025
24 checks passed
@Prashansa-K Prashansa-K deleted the refactor/convert-cmd branch April 22, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants