Skip to content

Conversation

harshadixit12
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.97%. Comparing base (dc862c3) to head (52d51c6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
+ Coverage   28.91%   28.97%   +0.05%     
==========================================
  Files          62       62              
  Lines        6765     6765              
==========================================
+ Hits         1956     1960       +4     
+ Misses       4667     4664       -3     
+ Partials      142      141       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CHANGELOG.md Outdated
### Fixed
- Fixed an issue where entities were replaced silently when ID was present in input files and select_tags didn't match.
[#1572](https://github.com/Kong/deck/pull/1572)
[go-database-reconciler #](https://github.com/Kong/go-database-reconciler/pull/214)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR numbers are left out here in [] and in the line below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you took inspiration from last few releases where I forgot too. 😂
I will add a PR to fix those.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase after that's merged

@harshadixit12 harshadixit12 force-pushed the docs/changelog-1.46.1 branch from 0b85425 to d35c3b0 Compare April 2, 2025 06:33
@harshadixit12
Copy link
Contributor Author

@harshadixit12 harshadixit12 merged commit f22457e into main Apr 3, 2025
24 checks passed
@harshadixit12 harshadixit12 deleted the docs/changelog-1.46.1 branch April 3, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync with --select-tag can replace existing certificate without indicating an update / delete if ID is mixed up by mistake
3 participants