Add [Exposed] Web IDL attribute to all WebGL interfaces. #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review. @kainino0x @jdashg @RafaelCintron @grorg |
kdashg
approved these changes
Jul 21, 2018
specs/latest/2.0/webgl2.idl
Outdated
| }; | ||
|
|
||
| interface WebGLVertexArrayObject : WebGLObject { | ||
| [Exposed=(Window,Worker)] interface WebGLVertexArrayObject : WebGLObject { |
There was a problem hiding this comment.
It would be nice the [Exposed... bit was always on the line before interface....
There was a problem hiding this comment.
Good point. Done throughout.
This extended attribute has been required by Web IDL since whatwg/webidl#423 . In order for WebGL to be accessible by web workers using OffscreenCanvas, the attribute being added to all WebGL interfaces is: [Exposed=(Window,Worker)] Fixes KhronosGroup#2571 .
8e68865 to
32841b5
Compare
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extended attribute has been required by Web IDL since
whatwg/webidl#423 . In order for WebGL to be accessible by web workers
using OffscreenCanvas, the attribute being added to all WebGL
interfaces is:
[Exposed=(Window,Worker)]
Fixes #2571 .