Fix recreateBytesPlane0 and add test #856
Conversation
|
@aqnuep there are now a small number of failures in the extract tool tests having to do with extracting Apologies for the bug in the previous version of I think I'm going to rename the function to |
|
*> What is a good way to examine the content of a .raw file?*
There's no easier way than to inspect the file in a hex viewer. You should
be able to compare the payloads.
But you can also try to feed that raw file back into ktx create, if that
makes it easier.
…-Daniel
On Fri, Feb 9, 2024 at 10:02 AM Mark Callow ***@***.***> wrote:
@aqnuep <https://github.com/aqnuep> there are now a small number of
failures in the extract tool tests having to do with extracting
X8_D24_UNORM_PACK32 format to .raw files. I suspect it because the
previous version of recreate... returned a value of 3 for this format.
The new one returns the correct 4. Most likely I just need to regenerate
the golden files. What is a good way to examine the content of a .raw file?
I can see the current golden file has a size of 192 while the new output is
256 bytes which suggests it is indeed due to the 4 instead of 3.
Apologies for the bug in the previous version of recreate....
I think I'm going to rename the function to reconstructBytesPlane0. I
prefer your "reconstruct" and the current name is too long. I think I'll
also make it return the value. For dfdutils users I'll have to provide a
wrapper for backward API compatibiility.
—
Reply to this email directly, view it on GitHub
<#856 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIBZY3NZORXIXVZ4M2Y5RXLYSXQ2ZAVCNFSM6AAAAABDAZTIXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVGU2TMMJUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The incorrect bytesPlane0 value messed up the calculation in |
The branch in .gitmodules is the the "tracked" branch. That confused me to in the past, don't worry about it. Only the commit hash the git module points to is relevant. |
for all valid VkFormats.
Remove duplicate declaration from unittests.
Remove duplicate export of recreateBytesPlane0 in write exports.
for easier use and better naming compatibility.
Update comment in mkvkformatfiles. Move check for VK_FORMAT_R16G16_S10_5_NV in test.
1472a39 to
625c560
Compare
of correct result for all valid VkFormats. Modify mkvkformatfiles to generate the list of valid format names to populate the table that drives the new test. Fix dfdutils Doxygen config file to include queries.c in the input.
of correct result for all valid VkFormats. Modify mkvkformatfiles to generate the list of valid format names to populate the table that drives the new test. Fix dfdutils Doxygen config file to include queries.c in the input.
of correct result for all valid VkFormats. Modify mkvkformatfiles to generate the list of valid format names to populate the table that drives the new test. Fix dfdutils Doxygen config file to include queries.c in the input.
of correct result for all valid VkFormats. Modify mkvkformatfiles to generate the list of valid format names to populate the table that drives the new test. Fix dfdutils Doxygen config file to include queries.c in the input.
of correct result for all valid VkFormats. Modify mkvkformatfiles to generate the list of valid format names to populate the table that drives the new test. Fix dfdutils Doxygen config file to include queries.c in the input.
for all valid VkFormats.
Merge needs to wait until issue #857 is fixed so it can be tested against correct DFDs.