-
Notifications
You must be signed in to change notification settings - Fork 70
Closed
Description
The following list outlines several enhancements and fixes required to improve methods and parameters clarity, maintainability, and usability of Python APIs.
-
**kwargs
should not have type, for exampleLab.new_machine(self, name: str, **kwargs: Dict[str, Any])
gives a warning in PyCharm
-
Manager
methodcopy_files(self, machine: Machine, guest_to_host: Dict[str, io.IOBase])
,guest_to_host
should beDict[str, Union[str, io.IOBase]]
sinceutils.pack_file_for_tar
acceptsfile_obj
with that type. -
lab.check_integrity
should be moved insidedeploy_lab
of Managers - Add device integrity check in
deploy_machine
- Add privileged checks (both for
privileged
andlab.ext
) inside the Managers instead of command (otherwise it is not raised by API). Forlab.ext
it should also be done in_attach_external_interfaces
inDockerLink
. Forprivileged
it should also be done inDockerManager
. - Add
connect_tty_obj
that takesMachine
object instead of name and no lab params, that internally calls theconnect_tty
with the right params - Add
exec_obj
that takesMachine
object instead of name and no lab params, that internally calls theexec
with the right params - Add
get_machine_stats_obj
that takesMachine
object instead of name and no lab params, that internally calls theget_machine_stats
with the right params - Add
get_link_stats_obj
that takesLink
object instead of name and no lab params, that internally calls theget_link_stats
with the right params - Add
stream=True/False
parameter inexec
that, ifFalse
, unrolls the stream and returns thebytes
results. - Separate lab options from global machine metadata.
-
PrivilegeError
ofmachine_stats
ifall_users=True
is now inListCommand
- add_line_before/after of
FilesystemMixin
should also take a Regex instead of a string
Metadata
Metadata
Labels
Type
Projects
Status
Done