Skip to content

fix: use molecule-plugins[docker] instead of just docker #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: use molecule-plugins[docker] instead of just docker #83

wants to merge 2 commits into from

Conversation

JonasPammer
Copy link
Owner

@JonasPammer JonasPammer commented Apr 26, 2023 •
edited
Loading

fixes a KeyError: 'docker' error i experienced on my devcontainer (both laptop and desktop) and which also happens in CI:

   File "/home/runner/work/cookiecutter-ansible-role/cookiecutter-ansible-role/ansible-role-myrole/.tox/py3-ansible-6/lib/python3.11/site-packages/molecule/api.py", line 30, in __getitem__
    return self.__dict__[i]
           ~~~~~~~~~~~~~^^^
KeyError: 'docker'
py3-ansible-6: exit 1 (0.84 seconds) /home/runner/work/cookiecutter-ansible-role/cookiecutter-ansible-role/ansible-role-myrole> molecule destroy pid=8844
  pre-commit: OK (5.13=setup[3.05]+cmd[2.08] seconds)
  py3-ansible-4: OK (208.70=setup[91.06]+cmd[0.74,17.08,2.63,97.19] seconds)
  py3-ansible-5: FAIL code 1 (103.82=setup[102.54]+cmd[0.42,0.85] seconds)
  py3-ansible-6: FAIL code 1 (34.50=setup[33.24]+cmd[0.42,0.84] seconds)

first kudo's go to robertdebock/ansible-role-bootstrap@d9a5f51 +
for completeness: a link to web archive showing mention of molecule-plugins in the official installation docs of molecule v5.0.0 as per ansible/molecule#3805

Required Checklist

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

@JonasPammer
ci: use molecule-plugins[docker]
f567488 
this does 2 things:
* fix a `KeyError: 'docker'` error i experienced on my devcontainer
* sucessfully run of fedora35 with ansible-6 on said local devcontainer
@JonasPammer JonasPammer self-assigned this Apr 26, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2023
@JonasPammer
Copy link
Owner Author

CI fails because of another cause (#81).. implement this in upstream!

@JonasPammer
Copy link
Owner Author

implemented in JonasPammer/cookiecutter-ansible-role#97

JonasPammer added a commit to JonasPammer/cookiecutter-ansible-role that referenced this pull request May 5, 2023
@JonasPammer
fix: don't mention docker dep itself
8c87d3c 
as done in JonasPammer/ansible-role-bootstrap#83
i think the whole reason i started said PR was because I wondered "why cap it at that without reason?".
molecule-plugins[docker] brings the docker dep, with a fitting ">" delimiter which for example brings us docker/docker-py#3116 thus this PR closes #103
@JonasPammer JonasPammer mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JonasPammer JonasPammer

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonasPammer