Fix signing when the developer ID contains non-ASCII characters. #5358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c86cf5 to
d6803da
Compare
d6803da to
564cd9a
Compare
terrakok
reviewed
Jul 10, 2025
| @@ -3,6 +3,7 @@ pluginManagement { | |||
| id 'org.jetbrains.kotlin.jvm' version 'KOTLIN_VERSION_PLACEHOLDER' | |||
| id 'org.jetbrains.kotlin.plugin.compose' version 'KOTLIN_VERSION_PLACEHOLDER' | |||
| id 'org.jetbrains.compose' version 'COMPOSE_GRADLE_PLUGIN_VERSION_PLACEHOLDER' | |||
| id 'org.gradle.toolchains.foojay-resolver-convention' version '1.0.0' | |||
There was a problem hiding this comment.
It's a plugin that automatically downloads and "installs" JDKs as needed. We need it because the tests now include testing with a JDK not installed by default (JDK 21, in testMacSignWithNonAsciiDeveloperId)
terrakok
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the developer id contains non-ASCII characters, the output of
security find-certificatesis different, and we need different code to parse it.Testing
Tested manually and added a unit test.
Note that the test is disabled, and it actually fails at the end, but it fails after the code in question, and the previously existing
macSigntest fails at the same place.Release Notes
Fixes - Gradle Plugin