Skip to content

Escape unicode filenames to fix incorrect mappings on some platforms #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Escape unicode filenames to fix incorrect mappings on some platforms #789

wants to merge 1 commit into from

Conversation

tlundeen
Copy link 

    //some filesystems treat different unicode characters as identical,
    //e.g. macOS treats Lo/ε (\u03b5) and Lo/ϵ (\u03f5) as the same character for filenames.
    //So escape packageElements strings to only use standard ascii

JesusFreke added a commit that referenced this pull request Feb 17, 2021
@JesusFreke
Handle unicode filename collisions on mac
1e655c2 
Some unicode characters are considered equivalent for filename purposes on mac.
This adds logic to treat these collisions the same way as case sensitivy
collisions are currently handled -- by adding a numeric suffix to the
file/directory anytime there is a collision.

See pull request #789 for more information.
@JesusFreke
Copy link
Owner

Hi, thanks for the report and pull request. I actually solved this problem slightly differently in 1e655c2, ensuring that this type of collision is handled the same as something like a collision due to case insensitivity.

@JesusFreke JesusFreke closed this Feb 17, 2021
@tlundeen
Copy link
Author

tlundeen commented Feb 17, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlundeen @JesusFreke