Skip to content

BUG+REL: Restore Python2.7 support #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2022
Merged

BUG+REL: Restore Python2.7 support #262

merged 3 commits into from
Apr 3, 2022

Conversation

scottclowe
Copy link
Contributor

Restores Python 2.7 support for a 1.7.5 hotfix before Python 2.7 support is dropped.

Tested on Python 2.7.18 on Ubuntu 20.04.4 with the following shell code:

sudo apt-get remove pandoc
rm -rf test
mkdir test
python

import os
import pypandoc
dirname = os.path.join(os.getcwd(), "test")
pypandoc.download_pandoc(targetfolder=dirname)
os.environ["PATH"] += os.pathsep + dirname
pypandoc.convert_file("test.md", "rst", outputfile="test/test.rst")
pypandoc.convert_file("README.md", "rst", outputfile="test/README.rst")
exit
PATH="${PATH}:${PWD}/test"
python tests.py

Once merged, the py27support branch needs to be built as a wheel and released as 1.7.5 on PyPI.

@scottclowe
Copy link
Contributor Author

Addresses #260.

@scottclowe scottclowe mentioned this pull request Apr 3, 2022
Merged
@scottclowe scottclowe changed the title BUG: Fix missing FileNotFoundError on python2.7 BUG+REL: Restore Python2.7 support (#260) Apr 3, 2022
@scottclowe scottclowe changed the title BUG+REL: Restore Python2.7 support (#260) BUG+REL: Restore Python2.7 support Apr 3, 2022
@JessicaTegner JessicaTegner merged commit 2fcce8b into JessicaTegner:py27support Apr 3, 2022
@JessicaTegner
Copy link
Owner

@scottclowe this is now published to v1.7.5

Sidenote: Should probably make a cd script that runs
python setup.py download_pandoc bdist_wheel sdist on all platforms automatically when tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottclowe @JessicaTegner