-
Notifications
You must be signed in to change notification settings - Fork 9
Adapt to https://github.com/coq/coq/pull/19530 #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah, example 55 seems indicative of an actual issue. And I'd like a backwards compatible patch, the minimizer should continue to work with older versions of Coq. Can we just use more regular expressions in the tests? |
Yes, I don't know what's happening there, would you mind having a look (I'd be happy to help if needed but I'm not sure I can do it myself, not being familiar with the minimizer, I don't precisely know what's expected and what's a correct or incorrect minimization result)
Other than this example_55 the remaining should be backward compatible |
81e2451
to
a44e442
Compare
According to the GitLab log, the relevant issue is
The minimizer reads Source code in the minimizer: coq-tools/coq_tools/find_bug.py Lines 1404 to 1411 in aa177d0
coq-tools/coq_tools/coq_version.py Lines 251 to 256 in aa177d0
|
Btw, probably |
a44e442
to
d938044
Compare
Thanks for the detailled explanation. So the file is now at
Do you know when was |
d938044
to
0993846
Compare
Co-authored-by: Jason Gross <jgross@mit.edu>
0993846
to
d0c2406
Compare
@JasonGross thanks for the help. CI seems mostly happy, it's only complaining on 8.4 about |
Only example 63 fails, and I've been working on that one separately, so let's merge. |
Thanks for your work preparing this! |
Thanks for your help |
Adapt to rocq-prover/rocq#19530
To be merged in sync with the upstream PR.
Most changes seem reasonable but example_055 may reveal an actual issue?