feat(jans-fido2) : added integration test cases for the device registration flow #11894

imran-ishaq · 2025-08-01T17:04:26Z

Description

Added the Integration tests for the complete flow of device Registration

Target issue

Currently, the Jans FIDO2 module lacks comprehensive integration testing for device registration workflows. This creates uncertainty about the reliability of FIDO2 device registration functionality in production environment

closes #11893

Implementation Details

Created structured test data for the FIDO2 integration flow
Configured the server dynamically during the test build process
Implemented test cases covering basic to advanced scenarios

Test and Document the changes

Static code analysis has been run locally and issues have been fixed
Relevant unit and integration tests have been added/updated
Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: imran <imranishaq7071@gmail.com>

Signed-off-by: Mustafa Baser <mbaser@mail.com>

Signed-off-by: imran <imranishaq7071@gmail.com>

Signed-off-by: Mustafa Baser <mbaser@mail.com>

Signed-off-by: Yuriy <Yuriy.Movchan@gmail.com>

Signed-off-by: imran <imranishaq7071@gmail.com>

Signed-off-by: Yuriy <Yuriy.Movchan@gmail.com>

Signed-off-by: imran <imranishaq7071@gmail.com>

…vice registration Signed-off-by: imran <imranishaq7071@gmail.com>

mo-auto · 2025-08-01T17:04:57Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

jgomer2001 · 2025-08-01T19:19:52Z

jans-casa/app/src/main/java/io/jans/casa/plugins/authnmethod/service/Fido2Service.java

I wonder if it is really necessary to remove those logging statements...

I agree with @jgomer2001 We can keep log message and just specify right severity for them

Ok I will add them

yurem

Please don't do code reformat. This makes review difficult

yurem · 2025-08-01T19:23:28Z

jans-casa/app/src/main/java/io/jans/casa/plugins/authnmethod/service/Fido2Service.java

I agree with @jgomer2001 We can keep log message and just specify right severity for them

yurem · 2025-08-01T19:24:21Z

jans-fido2/client/profiles/default/config-fido2-test.properties

@@ -0,0 +1 @@
+test.server.name=imran-ishaq-capable-cobra.gluu.info


In default profile it's better to specify generic hostname

yurem · 2025-08-01T19:25:18Z

jans-fido2/server/src/main/java/io/jans/fido2/service/mds/MdsService.java

@@ -1,21 +1,3 @@
-/*


We need to put:

* Janssen Project software is available under the MIT License (2008). See http://opensource.org/licenses/MIT for full text. * * Copyright (c) 2020, Janssen Project */

There is same question about log messages which @jgomer2001 raised in previous file

yurem · 2025-08-01T19:28:33Z

jans-fido2/server/src/main/java/io/jans/fido2/service/mds/MdsService.java

@@ -1,21 +1,3 @@
-/*


There is same question about log messages which @jgomer2001 raised in previous file

yurem · 2025-08-01T19:30:21Z

jans-fido2/server/src/main/java/io/jans/fido2/service/mds/TocService.java

 		} catch (Exception e) {
-			log.error("Failed to get nextUpdateDate of the MDS from jansDocument ", e);


We should log exceptions

yurem · 2025-08-01T19:32:39Z

...nux-setup/jans_setup/templates/test/jans-fido2/client/config-jans-fido2-test-data.properties

+fido2.client.id=FF81-2D39
+fido2.client.secret=%(jans_fido2_client_4_pw)s
+
+uma.user.uid=test_user


Are we using uma keys in properties?

yurem · 2025-08-01T19:33:08Z

...nux-setup/jans_setup/templates/test/jans-fido2/server/config-jans-fido2-test-data.properties

+ldap.admin.password=ldap_admin_test_password
+
+# Sector Identifiers (optional, for metadata or RP ID isolation testing)
+sector.identifier.id=a55ede29-8f5a-461d-b06e-76caee8d40b5


Is this needed for test?

…ns-fido2-test-server-2

Signed-off-by: imran <imranishaq7071@gmail.com>

sonarqubecloud · 2025-08-04T13:01:33Z

Quality Gate passed for 'Fido2 API'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-08-05T09:20:46Z

Quality Gate passed for 'jans-cli'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-08-05T09:21:52Z

Quality Gate failed for 'jans-linux-setup'

Failed conditions
1 New Bugs (required ≤ 0)
12 New Code Smells (required ≤ 8)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

imran-ishaq and others added 16 commits August 1, 2025 08:45

added templates for jans-fido2-test-server

ec0cb1e

Signed-off-by: imran <imranishaq7071@gmail.com>

feat(jans-linux-setup): fido test data loader

d3986d3

Signed-off-by: Mustafa Baser <mbaser@mail.com>

feat(jans-linux-setup): removed unnecessary files from test data loader

c9994a6

Signed-off-by: imran <imranishaq7071@gmail.com>

feat(jans-linux-setup): Resolved Typo Issue

83c4c3a

Signed-off-by: imran <imranishaq7071@gmail.com>

fix(jans-linux-setup): test client variables and placeholders

c50776d

Signed-off-by: Mustafa Baser <mbaser@mail.com>

fix(jans-linıx-setup): multiple test data loading

5a5571e

Signed-off-by: Mustafa Baser <mbaser@mail.com>

fix(jans-fido2): fix conflict

ca7b514

Signed-off-by: Yuriy <Yuriy.Movchan@gmail.com>

test: add integration test 1

0455261

Signed-off-by: imran <imranishaq7071@gmail.com>

test: add integration test 2

9f8895f

Signed-off-by: imran <imranishaq7071@gmail.com>

feat(jans-fido2): added integration testing 3

22271a1

Signed-off-by: imran <imranishaq7071@gmail.com>

feat(jans-fido2): added integration testing 4

8202e4a

Signed-off-by: imran <imranishaq7071@gmail.com>

fix(jans-fido2): fix conflict

c8ded67

Signed-off-by: Yuriy <Yuriy.Movchan@gmail.com>

fix(jans-fido2): fix conflict

0cbf91d

Signed-off-by: Yuriy <Yuriy.Movchan@gmail.com>

fix(jans-fido2): fix conflict

7b0dd1d

Signed-off-by: Yuriy <Yuriy.Movchan@gmail.com>

test: add integration test 1

ef42bd1

Signed-off-by: imran <imranishaq7071@gmail.com>

feat(jans-fido2): added integration tests for the complete flow of de…

6e4362f

…vice registration Signed-off-by: imran <imranishaq7071@gmail.com>

Merge branch 'main' into jans-fido2-test-server-2

ba643e2

imran-ishaq marked this pull request as ready for review August 1, 2025 17:10

imran-ishaq requested review from jgomer2001, devrimyatar, yuriyz, yurem and yuriyzz as code owners August 1, 2025 17:10

jgomer2001 reviewed Aug 1, 2025

View reviewed changes

yurem reviewed Aug 1, 2025

View reviewed changes

yurem requested changes Aug 1, 2025

View reviewed changes

imran-ishaq added 2 commits August 4, 2025 16:38

Merge branch 'main' of https://github.com/JanssenProject/jans into ja…

7270df9

…ns-fido2-test-server-2

feat(jans-fido2): refactored the requested changes

2e026f7

Signed-off-by: imran <imranishaq7071@gmail.com>

imran-ishaq requested a review from yurem August 4, 2025 13:03

yurem approved these changes Aug 4, 2025

View reviewed changes

devrimyatar approved these changes Aug 5, 2025

View reviewed changes

Merge branch 'main' into jans-fido2-test-server-2

719745c

devrimyatar merged commit 4582b98 into main Aug 5, 2025
2 checks passed

devrimyatar deleted the jans-fido2-test-server-2 branch August 5, 2025 09:19

ossdhaval assigned imran-ishaq and yurem Aug 6, 2025

		@@ -0,0 +1 @@
		test.server.name=imran-ishaq-capable-cobra.gluu.info

		} catch (Exception e) {
		log.error("Failed to get nextUpdateDate of the MDS from jansDocument ", e);

feat(jans-fido2) : added integration test cases for the device registration flow #11894

feat(jans-fido2) : added integration test cases for the device registration flow #11894

Uh oh!

Conversation

imran-ishaq commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Target issue

Implementation Details

Test and Document the changes

Uh oh!

mo-auto commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yurem left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 4, 2025

Quality Gate passed for 'Fido2 API'

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 5, 2025

Quality Gate passed for 'jans-cli'

Uh oh!

sonarqubecloud bot commented Aug 5, 2025

Quality Gate failed for 'jans-linux-setup'

Uh oh!

Uh oh!

imran-ishaq commented Aug 1, 2025 •

edited

Loading

mo-auto commented Aug 1, 2025 •

edited

Loading