Skip to content

refactor(jans-cedarling): move the cedar mapping info fields into a json object #11772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 29, 2025
Merged

refactor(jans-cedarling): move the cedar mapping info fields into a json object #11772

merged 20 commits into from
Jul 29, 2025

Conversation

0xtinkle
Copy link
Contributor

@0xtinkle 0xtinkle commented Jul 14, 2025 •
edited
Loading

Prepare

Description

Move Cedar mapping info fields into a json object

Target issue

closes #11709

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@0xtinkle
refactor: move the cedar mapping info fields into a json object
27e23f6 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle 0xtinkle self-assigned this Jul 14, 2025
@mo-auto
Copy link
Member

mo-auto commented Jul 14, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling kind-enhancement Issue or PR is an enhancement to an existing functionality labels Jul 14, 2025
0xtinkle and others added 7 commits July 14, 2025 21:02
@0xtinkle
Merge branch 'main' into jans-cedarling-11709
d7f7edd
@0xtinkle
fix: test, clippy issues
fbcd1da 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
fix: wasm test
07a5547 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
Merge branch 'main' into jans-cedarling-11709
a2d9f79
@0xtinkle
fix: wasm test
4e6dac4 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
fix: wasm test
ad33950 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
fix: wasm test
2368051 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
SafinWasi
SafinWasi requested changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation changes are needed. Python and Go bindings are functional but some small changes are required. Furthermore, @duttarnab needs to review the WASM, Kotlin and Java binding changes.

jans-cedarling/bindings/cedarling_go/structs.go
// Payload will be flattened into the JSON object.
Payload map[string]any
}

type CedarEntityMapping struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KrakenD plugin needs to be updated to reflect this. I will do it once this PR is merged.

duttarnab
duttarnab reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@duttarnab duttarnab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On testing the WASM binding: (branch: jans-cedarling-11709)

  1. Followed https://github.com/JanssenProject/jans/blob/jans-cedarling-11709/docs/cedarling/cedarling-wasm.md#building

  2. I could see type attribute is still used in resource object. The overall decision is true.

image
  1. On removing type attribute from resource object, I am getting missing field 'type'
image

duttarnab
duttarnab requested changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@duttarnab duttarnab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments.

  • UniFFI binding in Java/Android/Swift working properly.
  • Raised an bug in WASM binding.

@0xtinkle
Copy link
Contributor Author

0xtinkle commented Jul 16, 2025 •
edited
Loading

Please see the comments.

  • UniFFI binding in Java/Android/Swift working properly.
  • Raised an bug in WASM binding.

can you try again after rebuild wasm binding? or clear browser cache?
I believe it may be related with caching. @duttarnab

haileyesus2433
haileyesus2433 previously approved these changes Jul 16, 2025
View reviewed changes
0xtinkle added 2 commits July 17, 2025 19:53
@0xtinkle
fix: docs, bindings
9b9001d 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
fix: merge conflicts
dbe36cc 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
duttarnab
duttarnab previously approved these changes Jul 17, 2025
View reviewed changes
@0xtinkle 0xtinkle requested a review from SafinWasi July 17, 2025 17:53
SafinWasi
SafinWasi requested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CedarEntityData needs a constructor

@0xtinkle
feat: add CedarEntityMapping constructor in python binding
0bac6ce 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle 0xtinkle requested a review from SafinWasi July 18, 2025 16:00
0xtinkle and others added 5 commits July 21, 2025 15:50
@0xtinkle
fix: update EntityData constructor in python bindings
6b1c5f8 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
fix: merge conflicts
878da8a 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
docs: update cedarling-rust doc
68edd5e 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
fix: cedarling python binding init constructor
2c70aa4 
Signed-off-by: 0xtinkle <dbkey.one1@gmail.com>
@0xtinkle
Merge branch 'main' into jans-cedarling-11709
2847d88
SafinWasi
SafinWasi approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@0xtinkle 0xtinkle enabled auto-merge (squash) July 24, 2025 12:02
@0xtinkle 0xtinkle disabled auto-merge July 24, 2025 12:52
@0xtinkle 0xtinkle enabled auto-merge (squash) July 24, 2025 12:53
@duttarnab duttarnab mentioned this pull request Jul 25, 2025
Closed
@0xtinkle 0xtinkle merged commit bcc6d6a into main Jul 29, 2025
2 checks passed
@0xtinkle 0xtinkle deleted the jans-cedarling-11709 branch July 29, 2025 15:11
@SafinWasi SafinWasi mentioned this pull request Aug 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SafinWasi SafinWasi SafinWasi approved these changes

@duttarnab duttarnab duttarnab approved these changes

@haileyesus2433 haileyesus2433 haileyesus2433 approved these changes

Assignees

@0xtinkle 0xtinkle

Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(jans-cedarling)!: Move the Cedar mapping info fields into a json object
6 participants
@0xtinkle @mo-auto @SafinWasi @duttarnab @haileyesus2433 @moabu