Skip to content

feat(jans-cedarling): go binding for cedarling #11239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 30, 2025
Merged

Conversation

olehbozhok
Copy link
Contributor

Prepare


Description

Target issue

https://github.com/JanssenProject/jans/issues/11014

closes #11014

Implementation Details

Added Golang bindings. Actually it works like RPC communication between rust part and Golang part. When we need to pass complex structures it was used JSON as serialization.


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok requested review from rmarinn and SafinWasi April 17, 2025 12:41
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Apr 17, 2025
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-11014 branch 3 times, most recently from 56fccc8 to b880279 Compare April 17, 2025 13:50
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-11014 branch from b880279 to b141902 Compare April 17, 2025 13:59
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs work on the Readme and some discussion on how to properly package it, since its in a subdirectory of jans. Furthermore, this is missing documentation.

… need specify `LD_LIBRARY_PATH`

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
… minimum version

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-11014 branch 2 times, most recently from 8f8ed52 to 5f8e87c Compare April 18, 2025 09:06
…ing `sh build_and_copy_artifacts.sh`

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-11014 branch from 5f8e87c to 6bb13c8 Compare April 18, 2025 09:17
olehbozhok and others added 4 commits April 21, 2025 17:26
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
… package

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok marked this pull request as ready for review April 22, 2025 02:30
@olehbozhok olehbozhok requested a review from moabu as a code owner April 22, 2025 02:30
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-11014 branch from 05b7805 to 26e0928 Compare April 22, 2025 13:45
… used can download prebuild libs

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…s go section

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…atible with other packages

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@mo-auto
Copy link
Member

mo-auto commented Apr 22, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

olehbozhok and others added 7 commits April 23, 2025 01:42
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
@SafinWasi SafinWasi self-requested a review April 25, 2025 19:15
@moabu moabu merged commit 3a6334d into main Apr 30, 2025
2 checks passed
@moabu moabu deleted the jans-cedaling-issue-11014 branch April 30, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-cedarling): go binding for cedarling
5 participants