Skip to content

fix(jans-cedarling): entity builder not finding the 'iss' entity #11235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

rmarinn
Copy link
Contributor

@rmarinn rmarinn commented Apr 17, 2025

Prepare


Description

This PR fixes the issue where the iss attribute could not be found when there are multiple trusted issuers.

Target issue

closes #11233

Implementation Details

The entity id for the TrustedIssuer entities was changed from it's id on the policy store to it's origin. e.g.:

Jans::TrustedIssuer::"SomeIssuer" -> Jans::TrustedIssuer::"https://test.idp.com"

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

…ultiple

Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
@rmarinn rmarinn requested review from olehbozhok and SafinWasi April 17, 2025 07:12
@rmarinn rmarinn self-assigned this Apr 17, 2025
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@rmarinn rmarinn changed the title fix: not being able to find the TrustedIssuer entity when there are m… fix(jans-cedarling): entity builder not finding the 'iss' entity Apr 17, 2025
@mo-auto mo-auto added comp-jans-cedarling Touching folder /jans-cedarling kind-bug Issue or PR is a bug in existing functionality labels Apr 17, 2025
@rmarinn rmarinn enabled auto-merge (squash) April 17, 2025 14:54
@rmarinn rmarinn merged commit 3da7b4a into main Apr 17, 2025
1 check passed
@rmarinn rmarinn deleted the jans-cedarling-multiple-iss-bugfix branch April 17, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-cedarling): not being able to find the TrustedIssuer entity when there are multiple
4 participants