Skip to content

chore(jans-cedarling): add post to cedar schema #11227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

SafinWasi
Copy link
Contributor

Prepare


Description

Target issue

closes #11226

Implementation Details


Test and Document the changes

N/A

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi SafinWasi requested a review from olehbozhok April 15, 2025 16:26
@mo-auto mo-auto added comp-jans-cedarling Touching folder /jans-cedarling kind-dependencies Pull requests that update a dependency file labels Apr 15, 2025
@SafinWasi SafinWasi requested a review from nynymike April 15, 2025 16:27
@ossdhaval
Copy link
Contributor

@SafinWasi Suggestion on PR title: This PR should be a feat and not chore if you are adding a new capability that did not exist before.

@SafinWasi
Copy link
Contributor Author

@ossdhaval we are not adding a new feature here, this is simply adding the POST verb to the cedarling schema.

@SafinWasi SafinWasi enabled auto-merge (squash) April 22, 2025 17:48
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@SafinWasi SafinWasi merged commit dc5620d into main Apr 22, 2025
1 check passed
@SafinWasi SafinWasi deleted the chore-cedarling-add-post branch April 22, 2025 17:49
@mo-auto
Copy link
Member

mo-auto commented Apr 22, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(jans-cedarling): add POST to schema
5 participants