Skip to content

bug(jans-cedarling)!: Fix all tokens_metadata to token_metadata #11215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 17, 2025
Merged

bug(jans-cedarling)!: Fix all tokens_metadata to token_metadata #11215

merged 5 commits into from
Apr 17, 2025

Conversation

olehbozhok
Copy link
Contributor

Prepare

Description

Rename all tokens_metadata to token_metadata

Target issue

link

closes #11211

Implementation Details

Renamed all tokens_metadata to token_metadata

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@olehbozhok
chore!(jans-cedarling): rename tokens_metadata to token_metadata
3ff93c8 
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok
docs(jans-cedarling): rename tokens_metadata to token_metadata
7dd5fa4 
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok requested review from SafinWasi and rmarinn April 11, 2025 17:45
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling labels Apr 11, 2025
@olehbozhok olehbozhok requested a review from nynymike April 11, 2025 17:46
@olehbozhok
Copy link
Contributor Author

related https://github.com/GluuFederation/private/pull/11914

@olehbozhok
Copy link
Contributor Author

We need to merge it April 19 or 20, before prod release

@rmarinn
Copy link
Contributor

rmarinn commented Apr 12, 2025

We previously discussed that changing id_token to Id_token was a breaking change that was not worth it.

This might be the same case.

@olehbozhok
Copy link
Contributor Author

We previously discussed that changing id_token to Id_token was a breaking change that was not worth it.

This might be the same case.

@rmarinn it was request from Michael

@olehbozhok
Merge commit '2fffdd004edb3e4eb34918271e530d392b58a2f7' into jans-ced…
2f27598 
…aling-issue-11211

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok
chore(jans-cedarling): fix after merge
075330a 
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok
Merge commit '3da7b4a5c06c992cc7993df266338a7ded0f75e4' into jans-ced…
94d9850 
…aling-issue-11211
@olehbozhok olehbozhok enabled auto-merge (squash) April 17, 2025 15:22
@olehbozhok olehbozhok merged commit 1bbf2f2 into main Apr 17, 2025
2 checks passed
@olehbozhok olehbozhok deleted the jans-cedaling-issue-11211 branch April 17, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SafinWasi SafinWasi SafinWasi approved these changes

@rmarinn rmarinn rmarinn approved these changes

@nynymike nynymike Awaiting requested review from nynymike

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(jans-cedarling)!: fix all tokens_metadata to token_metadata
4 participants
@olehbozhok @rmarinn @SafinWasi @mo-auto