Skip to content

fix: fix the android and iOS sample app based on changes in cedarling uniffi binding #11294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 2, 2025

Conversation

duttarnab
Copy link
Contributor

@duttarnab duttarnab commented Apr 25, 2025

Prepare


Description

Target issue

closes #11279

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

… uniffi binding

Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
@mo-auto
Copy link
Member

mo-auto commented Apr 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@mo-auto mo-auto added comp-jans-cedarling Touching folder /jans-cedarling kind-bug Issue or PR is a bug in existing functionality labels Apr 25, 2025
… uniffi binding

Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
@duttarnab duttarnab marked this pull request as ready for review April 25, 2025 14:37
@duttarnab duttarnab requested review from olehbozhok, SafinWasi, rmarinn and nynymike and removed request for olehbozhok April 25, 2025 17:30
"CEDARLING_USER_AUTHZ": "enabled",
"CEDARLING_USER_WORKLOAD_BOOLEAN_OPERATION": "AND",
"CEDARLING_POLICY_STORE_URI": "https://raw.githubusercontent.com/duttarnab/cedarling_android/refs/heads/main/policy-store.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this links to your personal repo. should we have a copy of this policy store on the jans repo instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
@duttarnab duttarnab requested a review from rmarinn April 26, 2025 17:33
rmarinn
rmarinn previously approved these changes Apr 28, 2025
…roject root

Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my Pixel 4a

@moabu moabu merged commit c0a1948 into main May 2, 2025
2 checks passed
@moabu moabu deleted the jans-cedarling-issue-11279 branch May 2, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-cedarling): fix the android and iOS sample app based on changes in cedarling uniffi binding
6 participants