Skip to content

fix(docs): fix image paths in SAML SSO document #11183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

ossdhaval
Copy link
Contributor

@ossdhaval ossdhaval commented Apr 7, 2025

Prepare


Description

Target issue

closes #11182 #11184

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
@ossdhaval ossdhaval requested a review from Copilot April 7, 2025 09:54
@ossdhaval ossdhaval self-assigned this Apr 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

docs/janssen-server/keycloak/keycloak-saml-sso.md:69

  • [nitpick] Consider using a more descriptive alt text (e.g., 'SAML Service Provider setup') instead of the generic 'image' for improved accessibility.
![image](../../assets/SAML-Service-provider.png)

docs/janssen-server/keycloak/keycloak-saml-sso.md:73

  • [nitpick] Consider using a more descriptive alt text (e.g., 'SAML Release Attribute configuration') instead of the generic 'image' for clarity.
![image](../../assets/SAML-release-attribute.png)

docs/janssen-server/keycloak/keycloak-saml-sso.md:86

  • [nitpick] Consider using a more descriptive alt text (e.g., 'SP URL for SAML SSO testing') instead of the generic 'image' to improve comprehension.
![image](../../assets/sp-url.png)

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality labels Apr 7, 2025
@ossdhaval ossdhaval linked an issue Apr 8, 2025 that may be closed by this pull request
@ossdhaval ossdhaval requested review from mzico and manojs1978 April 8, 2025 08:05
@ossdhaval ossdhaval enabled auto-merge (squash) April 8, 2025 08:08
@ossdhaval ossdhaval merged commit 5abb790 into main Apr 8, 2025
2 checks passed
@ossdhaval ossdhaval deleted the docs-saml-sso-fix-image branch April 8, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(docs): remove unused images stored in the repository fix(docs): images are not getting rendered in SAML SSO document
4 participants