feat(jans-cedarling): add some logging msgs for jwt service startup #11178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
jans-cedarling/cedarling/src/jwt/mod.rs:31
- [nitpick] The blanket import 'use log::*;' may introduce ambiguity with the custom Logger implementation. Consider removing or refining this import to avoid confusion with other logging modules.
use log::*;
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
olehbozhok
approved these changes
Apr 11, 2025
SafinWasi
approved these changes
Apr 25, 2025
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
This PR just adds some logging at startup for the JWT validation service setup.
Target issue
closes #11177
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.