fix(jans-cedarling)!: role entity not being created in the unsigned interface #11176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**breaking changes**: - renamed: EntityData.payload to EntityData.attributes Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
jans-cedarling/cedarling/src/entity_builder/entity_id_getters.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
olehbozhok
requested changes
Apr 10, 2025
| attrs.into_iter().fold(HashMap::new(), |mut acc, attrs| { | ||
| acc.extend(attrs); | ||
| acc | ||
| }) | ||
| } else { |
There was a problem hiding this comment.
We can simplify code to
Suggested change
| } else { | |
| HashMap::from_iter(attrs.into_iter().flatten()) |
There was a problem hiding this comment.
resolved in b5a8d69
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
There are already tests in The |
Signed-off-by: rmarinn <34529290+rmarinn@users.noreply.github.com>
olehbozhok
approved these changes
Apr 11, 2025
SafinWasi
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
This PR fixes the issue where
Roleentities are not getting created in the unsigned interface.Target issue
closes #11160
Implementation Details
New Implementations
CEDARLING_UNSIGNED_ROLE_ID_SRCwas added so that Cedarling knows what to use when creating aRoleentity in the unsigned interface.authorize_unsigned.rsBreaking changes
EntityData.payloadhas been renamed toEntityData.attributes.Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.