Skip to content

feat(jans-cedarling): New interface: authorize_unsigned - send Principal as Object v. JWT #11035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Mar 26, 2025

Conversation

olehbozhok
Copy link
Contributor

@olehbozhok olehbozhok commented Mar 12, 2025

Prepare


Description

added support principals unverified by tokens

Target issue

link

closes #11000

Implementation Details

  • added method authorize_unverified that works like authorize but have another structure for request
pub struct RequestUnverified {
    /// Contains the JWTs that will be used for the AuthZ request
    pub principals: Vec<EntityData>,
    /// cedar_policy action
    pub action: String,
    /// cedar_policy resource data
    pub resource: EntityData,
    /// context to be used in cedar_policy
    pub context: serde_json::Value,
}

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…_entities`

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok requested a review from rmarinn March 12, 2025 20:37
@olehbozhok olehbozhok self-assigned this Mar 12, 2025
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Mar 12, 2025
@olehbozhok olehbozhok removed the area-documentation Documentation needs to change as part of issue or PR label Mar 12, 2025
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…rize_unsigned`

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok changed the title feat(jans-cedarling): Support Principals sent as Object v. JWT feat(jans-cedarling): New interface: authorizeUnverified - send Principal as Object v. JWT Mar 14, 2025
@mo-auto mo-auto added the area-documentation Documentation needs to change as part of issue or PR label Mar 14, 2025
…tion` to `InvalidPrincipal`

also removed `WorkloadRequestValidation` and `UserRequestValidation`

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok force-pushed the jans-cedaling-issue-11000 branch from d773778 to 6612793 Compare March 14, 2025 23:31
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…ult`

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
and rename `RequestUnverified` to `RequestUnsigned`

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@nynymike
Copy link
Contributor

Did we change the name from Unverified to Unsigned ?

… uid

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…an hold only string (#11015)

* docs(jans-cedarling): update usage of `CEDARLING_POLICY_STORE_LOCAL` in documentation

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

* docs(jans-cedarling): fix python documentation usage `CEDARLING_POLICY_STORE_LOCAL_FN` env var

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

---------

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
olehbozhok and others added 11 commits March 25, 2025 02:41
…aling-issue-11000

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…in JsonLogic

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…d` method

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
…aling-issue-11000

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok marked this pull request as ready for review March 25, 2025 17:24
@mo-auto mo-auto added the comp-docs Touching folder /docs label Mar 25, 2025
SafinWasi and others added 4 commits March 25, 2025 19:27
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>

Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>


Signed-off-by: Oleh Bozhok <olehbozhok@gmail.com>
@olehbozhok olehbozhok merged commit 37b72ad into main Mar 26, 2025
2 checks passed
@olehbozhok olehbozhok deleted the jans-cedaling-issue-11000 branch March 26, 2025 15:21
@nynymike nynymike changed the title feat(jans-cedarling): New interface: authorizeUnverified - send Principal as Object v. JWT feat(jans-cedarling): New interface: authorize_unsigned - send Principal as Object v. JWT Mar 27, 2025
@nynymike nynymike changed the title feat(jans-cedarling): New interface: authorize_unsigned - send Principal as Object v. JWT feat(jans-cedarling): New interface: authorize_unsigned - send Principal as Object v. JWT Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-cedarling): New interface: authorize_unsigned - send Principal as Object v. JWT