-
Notifications
You must be signed in to change notification settings - Fork 90
fix(docs): refresh agama lab quick start guide with respect to the latest Agama Lab version #10426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs changes, lots of links point to private assets.
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md
Outdated
Show resolved
Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md
Outdated
Show resolved
Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md
Outdated
Show resolved
Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md
Outdated
Show resolved
Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md
Outdated
Show resolved
Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md
Outdated
Show resolved
Hide resolved
docs/janssen-server/developer/agama/quick-start-using-agama-lab.md
Outdated
Show resolved
Hide resolved
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
DryRun Security SummaryThere are no code changes or files modified in the provided text, so no summary or review can be generated. Expand for full summarySummary: There are no code changes provided in the input, so I don't have any specific code changes to review or summarize. As an application security engineer, I would typically review any code changes in a pull request to ensure they do not introduce any security vulnerabilities or unintended consequences. Without any code changes to analyze, I don't have any specific security-related observations to provide. However, I'm ready to review any future code changes that may be submitted. Files Changed: There are no files changed in the provided input. Code AnalysisWe ran |
330f0c1
to
8b3fb2c
Compare
8b3fb2c
to
bbf379c
Compare
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Thank you for pointing this out. I tried many different things, not realising that this was the issue. 🤦♂️ 🤝 😃 |
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small correction, everything else looks good to me.
- Janssen Server instance | ||
- A public GitHub repository with at least one prior commit | ||
- We will use the [Janssen Server](https://jans.io) to deploy the Agama project. | ||
Follow the instructions [here](https://docs.jans.io/head/janssen-server/install/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the instructions [here](https://docs.jans.io/head/janssen-server/install/) | |
Follow the instructions [here](https://docs.jans.io/vreplace-janssen-version/janssen-server/install/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This PR has been replaced by a #10779 . This PR has all the discussions and comments but it couldn't be merged due to |
Prepare
Description
Target issue
closes #issue-number-here
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.