Skip to content

fix(jans-auth): fix client side jans-auth tests failures #10212 #10213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

yurem
Copy link
Contributor

@yurem yurem commented Nov 20, 2024

closes #10212

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@yurem yurem requested review from yuriyz and yuriyzz as code owners November 20, 2024 15:41
Copy link

dryrunsecurity bot commented Nov 20, 2024

DryRun Security Summary

The pull request primarily focuses on updating dependencies in the jans-bom/pom.xml file and making a minor change to the initialization of the HtmlUnitDriver in the BaseTest.java file, which are generally positive from an application security perspective as they update dependencies to newer versions and improve the robustness of the web automation tests.

Expand for full summary

Summary:

The changes in this pull request primarily focus on updating dependencies in the jans-bom/pom.xml file and making a minor change to the initialization of the HtmlUnitDriver in the BaseTest.java file. From an application security perspective, these changes are generally positive, as they update dependencies to newer versions, which may include security fixes or improvements.

The dependency updates in the pom.xml file for the commons-lang3, commons-text, and htmlunit-driver libraries are a good practice for maintaining the security and stability of the application. The change to the HtmlUnitDriver initialization, which sets the option to not throw an exception on script errors, is intended to improve the robustness of the web automation tests, and it does not introduce any significant security concerns.

However, it's important to ensure that the web application being tested is still secure and that any script errors or other issues are properly addressed, as they could potentially indicate underlying vulnerabilities or bugs in the application. Additionally, the use of the htmlunit library for web application testing should be reviewed to ensure that the tests are designed and executed in a secure manner.

Files Changed:

  1. jans-bom/pom.xml: This file has been updated to include newer versions of the commons-lang3, commons-text, and htmlunit-driver dependencies. These updates are generally positive from a security perspective, as they may address known vulnerabilities in the previous versions of these libraries.

  2. jans-auth-server/client/src/test/java/io/jans/as/client/BaseTest.java: The change in this file sets the HtmlUnitDriver to not throw an exception when a script error occurs during the execution of the web automation tests. This change is intended to improve the robustness of the test suite, and it does not introduce any significant security concerns.

  3. jans-auth-server/client/pom.xml: This file has been updated to include the org.apache.commons:commons-lang3 and org.htmlunit:htmlunit dependencies. The addition of these dependencies does not appear to introduce any immediate security concerns, but it's important to review them regularly to ensure they are up-to-date and secure.

Code Analysis

We ran 9 analyzers against 3 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 2 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-bom Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Nov 20, 2024
@yurem yurem enabled auto-merge (squash) November 20, 2024 16:40
@yurem yurem merged commit c0bc881 into main Nov 21, 2024
1 check passed
@yurem yurem deleted the issue_10212 branch November 21, 2024 12:18
Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

moabu pushed a commit that referenced this pull request May 2, 2025
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Co-authored-by: YuriyZ <91314855+yuriyzz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-bom Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-auth): fix client side jans-auth tests failures
5 participants