Skip to content

fix(jans-link): add missing configuration providers #10124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(jans-link): add missing configuration providers #10124

merged 2 commits into from
Nov 14, 2024

Conversation

yurem
Copy link
Contributor

@yurem yurem commented Nov 12, 2024

closes #10093

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@yurem yurem requested a review from yuriyz as a code owner November 12, 2024 16:20
@yurem yurem enabled auto-merge (squash) November 12, 2024 16:20
@mo-auto mo-auto added comp-jans-link Touching folder /jans-link kind-bug Issue or PR is a bug in existing functionality labels Nov 12, 2024
Copy link

dryrunsecurity bot commented Nov 12, 2024

DryRun Security Summary

The provided code changes focus on dependency management, configuration handling, and security-related aspects in the Janssen Project application, including the introduction of a ConfigurationService class for secure handling of sensitive data and changes to the ApplicationFactory class to improve the application's resilience and maintainability.

Expand for full summary

Summary:

The provided code changes cover several files within the Janssen Project application, primarily focusing on dependency management, configuration handling, and security-related aspects.

The changes in the pom.xml files involve the removal and addition of dependencies, as well as the exclusion of certain artifacts from a dependency. While these changes do not directly introduce security concerns, it is important to regularly monitor the project's dependencies for known vulnerabilities and update them as necessary to maintain the application's security posture.

The ConfigurationService class introduced in the ConfigurationService.java file is a positive security-focused change, as it provides methods for managing the application's configuration settings, including the secure handling of sensitive data like SMTP passwords and keystore passwords. The use of encryption and proper error handling in this class are good security practices.

The changes in the ApplicationFactory class focus on configuration management, including the handling of fallback configurations and the use of dependency injection. These changes help to improve the application's resilience and maintainability, which can have a positive impact on its overall security.

Files Changed:

  1. jans-link/service/pom.xml:

    • The version specification for the junit dependency has been removed, which is a routine dependency update.
    • From a security perspective, it is important to ensure that the updated dependency does not introduce any known vulnerabilities.
  2. jans-link/server/src/main/java/io/jans/link/server/service/ConfigurationService.java:

    • This new class is responsible for managing the application's configuration settings, including the secure handling of sensitive data like SMTP passwords and keystore passwords.
    • The use of encryption and proper error handling are positive security practices.
  3. jans-link/server/pom.xml:

    • The code change removes the dependency on the jans-core-document-store artifact and adds a new dependency on the jans-core-service artifact.
    • The exclusion of the jans-core-document-store and jans-core-message artifacts from the jans-core-service dependency should be investigated further to understand the potential security implications.
  4. jans-link/server/src/main/java/io/jans/link/service/config/ApplicationFactory.java:

    • The changes focus on configuration management, including the handling of fallback configurations and the use of dependency injection.
    • These changes help to improve the application's resilience and maintainability, which can have a positive impact on its overall security.

Code Analysis

We ran 9 analyzers against 4 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 2 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@shekhar16 shekhar16 self-requested a review November 14, 2024 14:20
@yurem yurem merged commit 7cc22ea into main Nov 14, 2024
1 check passed
@yurem yurem deleted the isue_10093 branch November 14, 2024 14:25
Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-link Touching folder /jans-link kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-link): unable to start jans-link for Unsatisfied dependencies
5 participants