Skip to content

chore: upgrade javascript libraries to newer versions in HTML files #10108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

mjatin-dev
Copy link
Contributor

@mjatin-dev mjatin-dev commented Nov 11, 2024

closes #7835

Closes #10109,

Copy link

dryrunsecurity bot commented Nov 11, 2024

DryRun Security Summary

The pull request primarily involves updating the Bootstrap CSS and JavaScript libraries used in the application to their latest versions, which generally improves security but requires thorough review and testing to ensure no unintended consequences or security issues are introduced.

Expand for full summary

Summary:

The code changes in this pull request primarily involve updates to the Bootstrap CSS and JavaScript libraries used in the application. The changes include updating the Bootstrap Reboot CSS, Popper.js, and Bootstrap Grid CSS files to the latest versions. These updates are generally positive from a security perspective, as they help ensure the application is using the latest versions of these libraries, which typically include bug fixes and security improvements.

However, it's important to thoroughly review and test the changes to ensure they do not introduce any unintended consequences or security issues. Updating to a new major version of a library like Bootstrap can sometimes introduce breaking changes, so the application should be thoroughly tested to ensure the updated files do not cause any visual or functional issues. Additionally, developers should continue to follow secure coding practices when integrating these libraries, such as properly sanitizing and validating user input and avoiding potential DOM-based vulnerabilities.

Files Changed:

  1. jans-auth-server/server/src/main/webapp/stylesheet/bootstrap-reboot.min.css:

    • The Bootstrap Reboot CSS file has been updated from version 4.0.0 to 5.3.3.
    • The changes include updates to the CSS variables, structure, and content to align with the new Bootstrap version.
    • From a security perspective, this update does not introduce any obvious security concerns, but the application should be thoroughly tested to ensure no unintended issues arise.
  2. jans-auth-server/server/src/main/webapp/js/popper.min.js:

    • The Popper.js library has been updated to the latest version (2.11.8).
    • This update includes bug fixes, performance improvements, and new features.
    • From a security perspective, keeping dependencies up-to-date is an important practice, but the code changes should still be reviewed to ensure no unintended consequences or security implications are introduced.
  3. jans-auth-server/server/src/main/webapp/stylesheet/bootstrap-grid.min.css:

    • The Bootstrap Grid CSS file has been updated from version 4.0.0 to 5.3.3.
    • The changes include updates to the CSS variables, class names, and structure of the grid system.
    • From a security perspective, these changes are mostly structural and do not introduce any obvious security concerns, but the application should be thoroughly tested to ensure no unintended visual or functional issues arise.

Code Analysis

We ran 9 analyzers against 7 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels Nov 11, 2024
@mo-auto
Copy link
Member

mo-auto commented Nov 11, 2024

Error: Hi @mjatin-dev, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@yuriyz yuriyz enabled auto-merge (squash) November 12, 2024 09:34
@yuriyz yuriyz merged commit 2970216 into main Nov 12, 2024
15 of 16 checks passed
@yuriyz yuriyz deleted the jans-auth-issue-7835 branch November 12, 2024 09:34
Copy link

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file
Projects
None yet
4 participants