-
Notifications
You must be signed in to change notification settings - Fork 90
chore(jans-cedarling): update python example and docs #10183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
DryRun Security SummaryThe pull request includes various updates to the Cedarling project, such as a README update, documentation improvements, and schema changes, with a focus on security-related aspects like dependency management, token handling, policy-based authorization, and data model updates. Expand for full summarySummary: The code changes in this pull request cover various updates to the Cedarling project, including a README update, documentation improvements, and schema changes. While the majority of the changes do not introduce any obvious security concerns, there are a few areas that warrant closer attention from an application security perspective. The key security-related aspects of these changes include:
Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
# show logs; only applicable to MemoryLogConfig logger | ||
#print("Logs stored in memory:") | ||
#print(*instance.pop_logs()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be best to simply remove the unused code.
@@ -2,7 +2,7 @@ | |||
from cedarling_python import PolicyStoreSource, PolicyStoreConfig, BootstrapConfig, JwtConfig | |||
from cedarling_python import Cedarling | |||
from cedarling_python import ResourceData, Request | |||
import os | |||
import os, time | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have something more structured, maybe it could be better to create functions like :
- initialize_logger()
- load_policy_store()
- create_request()
- process_authorization_result()
- ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
ee9b650
Prepare
Description
Target issue
closes #10182
Implementation Details
Test and Document the changes
N/A
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.