Skip to content

chore(jans-pycloudlib): remove ldap references from pycloudlib #10177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Nov 18, 2024

Prepare


Description

Target issue

closes #10175

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #10184

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli requested a review from moabu as a code owner November 18, 2024 17:43
Copy link

dryrunsecurity bot commented Nov 18, 2024

DryRun Security Summary

The provided setup.py file for the jans-pycloudlib Python package focuses on managing dependencies, including retaining the ldap3 library for critical functionality, specifying version requirements to mitigate vulnerabilities, and addressing a specific vulnerability (CVE-2022-36087) by updating the oauthlib library.

Expand for full summary

Summary:

The code changes in the provided setup.py file for the jans-pycloudlib Python package are primarily focused on addressing the dependency on the ldap3 library. The maintainers have made a conscious decision to keep the ldap3 library, as it is still used in critical parts of the codebase, such as the ldap_encode hashed function and the doc_id_from_dn parse_dn function. This decision is based on the fact that vendoring these functions would require additional test cases, which can be avoided by reusing the original functions from the ldap3 library.

Additionally, the package is specifying specific version requirements for its dependencies, which helps to ensure that the application is using known-good versions of the libraries and mitigates the risk of introducing vulnerabilities due to outdated dependencies. The package is also addressing a specific vulnerability (CVE-2022-36087) by updating the dependency on the oauthlib library to a version that resolves the issue. Overall, the code changes in the setup.py file demonstrate a proactive approach to dependency management and security, which is essential for maintaining the overall security posture of the application.

Files Changed:

  • jans-pycloudlib/setup.py: The changes in this file are focused on managing the dependencies of the jans-pycloudlib Python package. The key changes are:
    • The ldap3 library is being retained, as it is still used in critical parts of the codebase, such as the ldap_encode hashed function and the doc_id_from_dn parse_dn function.
    • The package is specifying specific version requirements for its dependencies, which helps to ensure that the application is using known-good versions of the libraries and mitigates the risk of introducing vulnerabilities due to outdated dependencies.
    • The package is addressing a specific vulnerability (CVE-2022-36087) by updating the dependency on the oauthlib library to a version that resolves the issue.

Code Analysis

We ran 9 analyzers against 4 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto
Copy link
Member

mo-auto commented Nov 19, 2024

Error: Hi @iromli, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-pycloudlib kind-dependencies Pull requests that update a dependency file labels Nov 19, 2024
Copy link

@moabu moabu merged commit a656ab6 into main Nov 19, 2024
10 of 11 checks passed
@moabu moabu deleted the cn-pycloudlib-ldap-ref branch November 19, 2024 06:39
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-pycloudlib kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: chore(jans-pycloudlib): remove ldap references from pycloudlib -autocreated chore(jans-pycloudlib): remove ldap references from pycloudlib
3 participants