Skip to content

feat(jans-cli-tui): session management #10164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2024
Merged

feat(jans-cli-tui): session management #10164

merged 4 commits into from
Nov 18, 2024

Conversation

devrimyatar
Copy link
Contributor

@devrimyatar devrimyatar commented Nov 15, 2024

Closes #10163

  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar marked this pull request as draft November 15, 2024 18:27
Copy link

dryrunsecurity bot commented Nov 15, 2024

DryRun Security Summary

The pull request implements session management and OAuth server management functionality within a command-line interface (CLI) application, focusing on security aspects such as input validation, permission checks, secure data handling, and session lifecycle management.

Expand for full summary

Summary:

The code changes in this pull request focus on implementing session management and OAuth server management functionality within a command-line interface (CLI) application. The key security-related aspects of these changes are:

  1. Session Management: The changes in the sessions.py file introduce session management features, including the ability to search, view, and delete user sessions. The code includes input validation, permission checks, and asynchronous processing to ensure security and responsiveness.

  2. OAuth Server Management: The changes in the main.py file introduce an "oauth" plugin that handles the management of OAuth-related entities, such as clients, scopes, keys, and logging configurations. The code includes functionality to retrieve, display, and update these entities, with a focus on secure data handling and access control.

  3. Session Lifecycle Configuration: The documentation changes in the README.md file provide an overview of the session-related configuration options in the Auth Server, such as session lifetime and inactivity timeouts. These settings are crucial for maintaining appropriate session security.

  4. Session Revocation: The documentation mentions the availability of session revocation endpoints, which allow administrators to quickly invalidate compromised or unwanted sessions, a critical security feature.

Overall, the code changes and documentation demonstrate a well-designed session management and OAuth server management system with a focus on security, flexibility, and administrative control. The various security-related aspects, such as input validation, permission checks, secure data handling, and session lifecycle management, are in line with best practices for secure application development.

Files Changed:

  1. jans-cli-tui/cli_tui/plugins/010_auth_server/sessions.py: This file introduces session management features, including the ability to search, view, and delete user sessions. The code includes input validation, permission checks, and asynchronous processing to ensure security and responsiveness.

  2. jans-cli-tui/cli_tui/plugins/010_auth_server/main.py: This file introduces an "oauth" plugin that handles the management of OAuth-related entities, such as clients, scopes, keys, and logging configurations. The code includes functionality to retrieve, display, and update these entities, with a focus on secure data handling and access control.

  3. docs/janssen-server/auth-server/session-management/README.md: This file provides an overview of the session-related configuration options in the Auth Server, such as session lifetime and inactivity timeouts, as well as information about session data storage and session event interception scripts.

Code Analysis

We ran 9 analyzers against 4 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-cli-tui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Nov 15, 2024
Copy link

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar marked this pull request as ready for review November 15, 2024 18:46
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs labels Nov 15, 2024
@yuriyz yuriyz enabled auto-merge (squash) November 18, 2024 09:48
@yuriyz yuriyz merged commit 180dd31 into main Nov 18, 2024
11 checks passed
@yuriyz yuriyz deleted the jans-cli-tui-sessions branch November 18, 2024 09:49
Copy link

Copy link

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cli-tui Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-cli-tui): session management
4 participants