Skip to content

Conversation

devrimyatar
Copy link
Contributor

Closes #10153

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-linux-setup Component affected by issue or PR labels Nov 15, 2024
@yuriyz yuriyz enabled auto-merge (squash) November 18, 2024 09:44
Copy link

DryRun Security Summary

The pull request updates the role-scope-mappings.json file to add new permissions related to session management and read-only access to configuration data, and grants these permissions to the api-admin role, expanding the administrative capabilities of the Jans Auth Server application.

Expand for full summary

Summary:

The code changes in this pull request appear to be an update to the role-scope-mappings.json file, which defines the permissions and roles for the Jans Auth Server application. The key changes include the addition of new permissions related to session management and read-only access to configuration data, as well as the granting of these new permissions to the api-admin role.

From an application security perspective, these changes suggest that the application is expanding its administrative capabilities, particularly around user session management and access to configuration data. It's important to ensure that these new permissions are granted only to the necessary roles and that the application's access control mechanisms are properly implemented and tested to prevent unauthorized access or abuse. Additionally, it's recommended to review the existing permissions and roles to ensure that the least-privilege principle is being followed, and that users are granted only the minimum permissions required to perform their tasks.

Files Changed:

  • jans-linux-setup/jans_setup/templates/jans-auth/role-scope-mappings.json: This file has been updated to include the following changes:
    • New permissions added:
      • https://jans.io/oauth/jans-auth-server/session.delete: Allows deleting user sessions.
      • revoke_session: Allows revoking user sessions.
      • https://jans.io/oauth/config/data.readonly: Allows read-only access to configuration data.
    • Role permissions changes:
      • The api-admin role has been granted the new session.delete and revoke_session permissions, which allow for more extensive control over user sessions.
      • The api-admin role has also been granted the new data.readonly permission, which provides read-only access to the application's configuration data.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@yuriyz yuriyz merged commit 9888248 into main Nov 18, 2024
11 checks passed
@yuriyz yuriyz deleted the jans-linux-setup-api-admin-scopes-10153 branch November 18, 2024 09:47
Copy link

Copy link

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-linux-setup): api-admin revoking session permissions
3 participants