Skip to content

chore(jans-cedarling): remove ipaddr #10140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore(jans-cedarling): remove ipaddr #10140

merged 1 commit into from
Nov 13, 2024

Conversation

SafinWasi
Copy link
Contributor

Prepare


Description

Target issue

closes #10139

Implementation Details


Test and Document the changes

N/A

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
Copy link

DryRun Security Summary

The pull request focuses on restructuring and reorganizing the schema definition for the cedarling_core.json and cedarling_core.cedarschema files, including the removal of the email_address entity type, restructuring of the Context entity type, and the addition/removal of various other entity types and actions.

Expand for full summary

Summary:

The changes in this pull request appear to be focused on restructuring and reorganizing the schema definition for the cedarling_core.json and cedarling_core.cedarschema files. The key changes include the removal of the email_address entity type, restructuring of the Context entity type, and the addition/removal of various other entity types and actions.

From an application security perspective, the changes do not introduce any obvious security concerns. However, it's important to review the overall context of the application and understand how these changes might impact the security posture. The removal of the email_address entity type could have implications for user authentication and authorization, and the addition of the HTTP_Request entity type suggests that the application is handling HTTP requests, which may require additional security considerations.

Additionally, the changes to the Context type definition, specifically the modification of the network field from an IP address type to a generic String type, could potentially introduce security risks if the data is not properly validated and sanitized. The various entities, actions, and contextual information defined in the schema should also be reviewed to ensure that they are implemented securely and follow best practices for handling sensitive data and access control.

Files Changed:

  1. jans-cedarling/schema/cedarling_core.json:

    • Removal of the email_address entity type and its associated attributes.
    • Restructuring of the Context entity type, removing the network attribute and making it a simple String type.
    • Reorganization of the entityTypes section, with the removal of the TrustedIssuer and Userinfo_token entity types, and the addition of the id_token and HTTP_Request entity types.
    • Rearrangement of the actions section, with the addition of new actions like DELETE and the removal of some actions like Compare.
  2. jans-cedarling/schema/cedarling_core.cedarschema:

    • Modification of the network field in the Context type definition from an ipaddr type to a String type.
    • The rest of the file appears to be the full contents of the cedarling_core.cedarschema file, which defines various types, entities, and actions for the Jans Cedarling application.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-cedarling Touching folder /jans-cedarling kind-dependencies Pull requests that update a dependency file labels Nov 13, 2024
@nynymike nynymike self-requested a review November 13, 2024 17:09
@moabu moabu merged commit 9801df4 into main Nov 13, 2024
20 checks passed
@moabu moabu deleted the docs-jans-cedarling-schema branch November 13, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(jans-cedarling): remove ipaddr from default schema
4 participants