Skip to content

fix(jans-bom): define plugins in base parent project #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

yurem
Copy link
Contributor

@yurem yurem commented Nov 7, 2024

closes #10086

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@yurem yurem requested a review from jgomer2001 November 7, 2024 19:33
Copy link

dryrunsecurity bot commented Nov 7, 2024

DryRun Security Summary

The changes in this pull request primarily involve updates to the Maven build configuration for the jans-link-server project, including the introduction of a parent "jans-bom" project for centralized dependency management, and the addition of security-related plugins to improve the project's security, quality, and maintainability.

Expand for full summary

Summary:

The changes in this pull request are primarily related to updates in the Maven build configuration for the jans-link-server project and the introduction of a parent "jans-bom" project for centralized dependency management.

The changes in the pom.xml files for the jans-link-server and the parent "jans-bom" project do not directly introduce any security vulnerabilities. The updates are focused on project structure, dependency management, and the inclusion of security-related plugins like dependency-check-maven, jacoco-maven-plugin, and spotbugs-maven-plugin.

While these changes do not raise any immediate security concerns, it is important to review the overall dependencies and configurations of the project to ensure that there are no other security-related issues. Additionally, it is recommended to periodically review the project's dependencies and their versions to keep the application secure and up-to-date.

Files Changed:

  1. jans-link/server/pom.xml: The changes involve the removal of the <version>3.3.1</version> configuration for the maven-war-plugin. This change is unlikely to have a significant impact on the security of the application.

  2. jans-link/pom.xml: The project has been set as a child of the "jans-bom" BOM project, which likely provides centralized management of dependency versions and other project-wide configurations. The <build> section, which previously contained plugin management configurations, has been removed.

  3. jans-bom/pom.xml: The changes include the addition of a new <build> section with <pluginManagement> that defines versions for various Maven plugins, including security-related plugins like dependency-check-maven, jacoco-maven-plugin, and spotbugs-maven-plugin. This suggests a focus on improving the project's security, quality, and maintainability.

Code Analysis

We ran 9 analyzers against 3 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 3 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-bom Component affected by issue or PR comp-jans-link Touching folder /jans-link kind-bug Issue or PR is a bug in existing functionality labels Nov 7, 2024
@yurem yurem marked this pull request as ready for review November 8, 2024 16:39
@yurem yurem requested review from yuriyz and yuriyzz as code owners November 8, 2024 16:39
@yuriyz yuriyz enabled auto-merge (squash) November 8, 2024 16:51
@yuriyz yuriyz merged commit f2a87d0 into main Nov 8, 2024
11 checks passed
@yuriyz yuriyz deleted the maven_build_plugin branch November 8, 2024 16:51
Copy link

sonarqubecloud bot commented Nov 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-bom Component affected by issue or PR comp-jans-link Touching folder /jans-link kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-bom): define maven plugin version in one parent project
4 participants