Skip to content

chore(jans-linux-setup) remove spanner db #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

devrimyatar
Copy link
Contributor

@devrimyatar devrimyatar commented Nov 6, 2024

closes #10044

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #10069,

Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar added the kind-enhancement Issue or PR is an enhancement to an existing functionality label Nov 6, 2024
Copy link

dryrunsecurity bot commented Nov 6, 2024

DryRun Security Summary

The provided code changes focus on the removal of support for the Google Cloud Spanner database in the Jans application setup process, simplifying the database-related functionality by focusing solely on MySQL and PostgreSQL as the supported relational database management systems (RDBMS), and improving the installation and configuration of the application with a strong emphasis on security-related aspects.

Expand for full summary

Summary:

The provided code changes focus on the removal of support for the Google Cloud Spanner database in the Jans application setup process. This includes the removal of Spanner-related configuration variables, logic, and dependencies across various components of the application. The changes also involve simplifying the database-related functionality by focusing solely on MySQL and PostgreSQL as the supported relational database management systems (RDBMS).

From an application security perspective, the removal of Spanner support is a positive change as it reduces the attack surface and complexity of the application. Simplifying the codebase and removing unused features can help improve the overall security and maintainability of the application. However, it's important to ensure that the removal of Spanner support does not introduce any unintended consequences or impact the application's functionality.

Additionally, the code changes include updates to the Jetty installer, RDBM installer, Jans Auth Server setup, and various utility files. These changes focus on improving the installation and configuration of the application, with a strong emphasis on security-related aspects such as password management, data integrity, JSON data handling, and LDAP configuration.

Files Changed:

  1. jans-linux-setup/jans_setup/setup_app/config.py: Removal of Spanner-related configuration variables and logic.
  2. jans-linux-setup/jans_setup/setup_app/installers/jetty.py: Updates to the Jetty installer, including the removal of Spanner-specific logic.
  3. jans-linux-setup/jans_setup/setup_app/installers/rdbm.py: Improvements to the RDBM installer, including secure password generation and data integrity checks.
  4. jans-linux-setup/jans_setup/setup_app/installers/jans_auth.py: Enhancements to the Jans Auth Server setup, such as OIDC key generation and pairwise calculation.
  5. jans-linux-setup/jans_setup/setup_app/static.py: Removal of unused backend types and their corresponding string representations.
  6. jans-linux-setup/jans_setup/setup_app/utils/arg_parser.py: Removal of Spanner-related command-line arguments.
  7. jans-linux-setup/jans_setup/setup_app/setup_options.py: Simplification of the RDBM configuration options.
  8. jans-linux-setup/jans_setup/setup_app/utils/collect_properties.py: Secure handling of sensitive information and configuration settings.
  9. jans-linux-setup/jans_setup/setup_app/test_data_loader.py: Removal of Spanner-related test data loading functionality.
  10. jans-linux-setup/jans_setup/setup_app/utils/properties_utils.py: Removal of Spanner-related code and simplification of the persistence type handling.
  11. jans-linux-setup/jans_setup/setup_app/utils/db_utils.py: Removal of Spanner-related database utility functions.
  12. jans-linux-setup/jans_setup/static/rdbm/sql_data_types.json: Removal of Spanner-specific data type configurations.
  13. jans-linux-setup/jans_setup/static/rdbm/ldap_sql_data_type_mapping.json: Removal of the Spanner section from the LDAP-SQL data type mapping.
  14. jans-linux-setup/jans_setup/tests/analyzer.py: Improvements to the log analysis tool, including database operation tracking and backend detection.

Code Analysis

We ran 9 analyzers against 18 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-linux-setup Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels Nov 6, 2024
@mo-auto
Copy link
Member

mo-auto commented Nov 6, 2024

Error: Hi @devrimyatar, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

Copy link

sonarqubecloud bot commented Nov 6, 2024

@yuriyz yuriyz enabled auto-merge (squash) November 6, 2024 20:35
@yuriyz yuriyz merged commit 6e00e72 into main Nov 6, 2024
12 checks passed
@yuriyz yuriyz deleted the jans-linux-setup-remove-spanner-10040-new branch November 6, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-dependencies Pull requests that update a dependency file kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: chore(jans-linux-setup) remove spanner db -autocreated
4 participants