-
Notifications
You must be signed in to change notification settings - Fork 90
chore(jans-linux-setup) remove spanner db #10068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
DryRun Security SummaryThe provided code changes focus on the removal of support for the Google Cloud Spanner database in the Jans application setup process, simplifying the database-related functionality by focusing solely on MySQL and PostgreSQL as the supported relational database management systems (RDBMS), and improving the installation and configuration of the application with a strong emphasis on security-related aspects. Expand for full summarySummary: The provided code changes focus on the removal of support for the Google Cloud Spanner database in the Jans application setup process. This includes the removal of Spanner-related configuration variables, logic, and dependencies across various components of the application. The changes also involve simplifying the database-related functionality by focusing solely on MySQL and PostgreSQL as the supported relational database management systems (RDBMS). From an application security perspective, the removal of Spanner support is a positive change as it reduces the attack surface and complexity of the application. Simplifying the codebase and removing unused features can help improve the overall security and maintainability of the application. However, it's important to ensure that the removal of Spanner support does not introduce any unintended consequences or impact the application's functionality. Additionally, the code changes include updates to the Jetty installer, RDBM installer, Jans Auth Server setup, and various utility files. These changes focus on improving the installation and configuration of the application, with a strong emphasis on security-related aspects such as password management, data integrity, JSON data handling, and LDAP configuration. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
Error: Hi @devrimyatar, You did not reference an open issue in your PR. I attempted to create an issue for you. |
|
closes #10044
Closes #10069,