Skip to content

Package Decoding Fixes #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2019
Merged

Package Decoding Fixes #80

merged 2 commits into from
Sep 11, 2019

Conversation

fredpi
Copy link
Contributor

@fredpi fredpi commented Sep 10, 2019

Closes #79

As there's also another issue with Nimble v8.0.3 (see Quick/Nimble#686), we should wait until that issue is resolved before testing whether this fix works properly.

@fredpi fredpi changed the title Package decoding Package Decoding Fixes Sep 10, 2019
Jeehut
Jeehut approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@Jeehut Jeehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. Merging. 🎉

@Jeehut Jeehut merged commit 62819d3 into stable Sep 11, 2019
@fredpi fredpi deleted the work/#79-package-decoding branch September 11, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Jeehut Jeehut Jeehut approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accio isn't compatible with certain Package.swift formats
2 participants
@fredpi @Jeehut