Skip to content

Remove duplicated processing of frameworks #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2019
Merged

Remove duplicated processing of frameworks #53

merged 2 commits into from
Jun 19, 2019

Conversation

fredpi
Copy link
Contributor

@fredpi fredpi commented May 28, 2019 •
edited
Loading

Remove duplicated processing of frameworks referenced by multiple other frameworks.

Closes #51.

@fredpi fredpi requested a review from mrylmz May 28, 2019 17:33
@Jeehut Jeehut mentioned this pull request Jun 11, 2019
Closed
Jeehut
Jeehut reviewed Jun 11, 2019
View reviewed changes
@fredpi fredpi force-pushed the work/#51-duplicate-processing branch from 46aface to 966acc8 Compare June 18, 2019 20:30
@fredpi fredpi force-pushed the work/#51-duplicate-processing branch from 966acc8 to b8d3adb Compare June 18, 2019 20:34
@fredpi
Copy link
Contributor Author

fredpi commented Jun 18, 2019

@Dschee This should be ready to be merged now

Jeehut
Jeehut approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@Jeehut Jeehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging! 🎉

@Jeehut Jeehut merged commit f4d0825 into stable Jun 19, 2019
@fredpi fredpi deleted the work/#51-duplicate-processing branch June 20, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrylmz mrylmz Awaiting requested review from mrylmz

2 more reviewers

@acecilia acecilia acecilia left review comments

@Jeehut Jeehut Jeehut approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accio attempts to build the same dependency multiple times
3 participants
@fredpi @Jeehut @acecilia