Improve warning about missing schemes #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredpi CI is failing, which makes sense: Please fix. |
|
@Dschee My bad, it's not that hard 😂 |
Jeehut
approved these changes
Jun 18, 2019
adc782d to
afef1ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case covered with this code is an edge case that would have otherwise been handled a few lines below with the following text:
⚠️ No shared scheme(s) found matching library name 'SwiftEntryKit' – can't remove potentially unnecessary shared schemes, keeping allAs that text is misleading if there a no schemes at all, it's suitable to explicitly handle this case.