Skip to content

Added the Prevent composition overwrite tests #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2017

Conversation

JSkimming
Copy link
Owner

These tests define the expected behaviour once #14 is resolved.

There are several tests that pass and should continue to pass, to ensure that the changes do not break existing functionality. There are also three skipped tests, that currently fail, though they express the desired behaviour.

@jzabroski if you're still interested, please dive in.

@codecov-io
Copy link

codecov-io commented May 8, 2017

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          51       51           
  Lines        1299     1299           
  Branches      233      233           
=======================================
  Hits         1298     1298           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c352b8...1c48d3a. Read the comment docs.

@JSkimming JSkimming merged commit 29549f5 into master May 8, 2017
@JSkimming JSkimming deleted the composition-overwrite branch May 8, 2017 11:59
@JSkimming JSkimming self-assigned this May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants