Skip to content

Added mechanism for singleton instance injection #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2017
Merged

Added mechanism for singleton instance injection #17

merged 4 commits into from
Apr 30, 2017

Conversation

JSkimming
Copy link
Owner

This will make it possible to provide singleton service instances at registrations like this

new RegistrationSetup()
    .RegisterFixed(new Service1())
    .RegisterFixed<IService2>(new Service2());

@JSkimming JSkimming self-assigned this Apr 30, 2017
@codecov-io
Copy link

codecov-io commented Apr 30, 2017 •
edited
Loading

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          37     41    +4     
  Lines         901    970   +69     
  Branches      176    185    +9     
=====================================
+ Hits          901    970   +69
Impacted Files Coverage Δ
...jectedSingletonRegistrationCompositionExtension.cs 100% <100%> (ø)
src/Abioc/Registration/RegistrationSetupBase.cs 100% <100%> (ø) ⬆️
...ition/Compositions/InjectedSingletonComposition.cs 100% <100%> (ø)
...n/Visitors/InjectedSingletonRegistrationVisitor.cs 100% <100%> (ø)
...bioc/Registration/InjectedSingletonRegistration.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d857815...f8ba082. Read the comment docs.

@JSkimming JSkimming force-pushed the injected-singleton branch from 7d54081 to 8e58a86 Compare April 30, 2017 14:08
@JSkimming JSkimming merged commit 9a66441 into master Apr 30, 2017
@JSkimming JSkimming deleted the injected-singleton branch April 30, 2017 14:38
@JSkimming JSkimming mentioned this pull request May 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JSkimming JSkimming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSkimming @codecov-io