Skip to content

Fix run-unit-tests issue with finding acroname #8444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2021

Conversation

maloel
Copy link
Contributor

@maloel maloel commented Feb 25, 2021

No description provided.

@maloel maloel requested a review from Nir-Az February 25, 2021 12:39
log.progress( '[' + ' '.join( configuration ) + ']', test.name, '...' )
else:
log.progress( test.name, '...' )
if not log.is_debug_on() or log.is_color_on():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add the color check?
Not just debug check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If color is on, then the terminal supports advanced controls and progress will not stay on-screen. I wanted to avoid the progress since debug includes the same information, for readability on the libci logs. But when I run it locally, I run with debug and I have color, so it still shows progress...

acroname = None
#
sys.path = sys.path[:-1] # remove what we added
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use a third party lib like numpy in our test it will not work right?
If yes, than we need to think of another way to solve this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it won't work (unless numpy isn't in site-packages) unless the module is in lib/.
One thing I can do is remove site-packages before loading librealsense, but it's hard to control when a script imports pyrs.
For now, it'll work.

@maloel maloel merged commit 7549827 into IntelRealSense:development Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants