L515 update tagged profiles for usb2 #7126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nir-Az
commented
Aug 18, 2020
- Remove raw resolutions processing blocks - Tracked on RS5-8384
- Update L515 tagged profiles to support USB2 resolutions
- Remove viewer resolutions + FPS constrains for USB 2 (behavior stayed the same due to tagged profiles)
maloel
reviewed
Aug 19, 2020
src/l500/l500-color.cpp
Outdated
|
|
||
| uint32_t width = usb3mode ? 1280 : 960; | ||
| uint32_t height = usb3mode ? 720 : 540; | ||
|
|
||
| tags.push_back({ RS2_STREAM_COLOR, -1, 1280, 720, RS2_FORMAT_RGB8, 30, profile_tag::PROFILE_TAG_SUPERSET | profile_tag::PROFILE_TAG_DEFAULT }); |
There was a problem hiding this comment.
Shouldn't this be using width & height?
There was a problem hiding this comment.
Correct - Fixed.
It passed my test cause on USB2 the color sensor only have 1 resolution.
maloel
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.