Skip to content

pybind linux - Fix missing debug symbols in RelWithDebug mode #7812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Nov 18, 2020

The output binary .so file of building pyrealsense2 on Linux and on configuration RelWithDebInfo does not contain symbols.

This is cause due to a known issue at pybind11 version 2.2.1 that is used in librealsense SDK.
The issue was fixed at PR1892 at pybind11 repo.

This PR implement the same fix.

Linux python 2.7 wheel size before this changes is : ~10 [MB]
Linux python 2.7 wheel size after this changes is : ~70 [MB]

Copy link
Contributor

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about it before we merge

@maloel maloel merged commit 25afe61 into IntelRealSense:development Nov 25, 2020
@Nir-Az Nir-Az deleted the pybind_build_with_symbols_on_linux branch December 23, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants