Skip to content

Add L515 humidity temperature option #7490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Add L515 humidity temperature option #7490

merged 1 commit into from
Oct 5, 2020

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Oct 4, 2020 •
edited
Loading

Tracked on [RS5-9069]

GUI illustration :
image

@Nir-Az Nir-Az requested a review from ev-mp October 4, 2020 09:06
ev-mp
ev-mp reviewed Oct 4, 2020
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the missing enumerations

@Nir-Az Nir-Az force-pushed the add_hum_sensor_to_viewer branch from cfd8a1c to 20fa453 Compare October 4, 2020 12:29
@Nir-Az Nir-Az requested a review from ev-mp October 4, 2020 12:32
ev-mp
ev-mp reviewed Oct 5, 2020
View reviewed changes
include/librealsense2/h/rs_option.h Outdated
RS2_OPTION_SEQUENCE_SIZE, /**< HDR Sequence size */
RS2_OPTION_SEQUENCE_ID, /**< HDR Sequence ID - 0 is not HDR; sequence ID for HDR configuartion starts from 1 */
RS2_OPTION_HUMIDITY_TEMPERATURE, /**< Humidity temperature*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls specify units

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Nir-Az Nir-Az force-pushed the add_hum_sensor_to_viewer branch from 20fa453 to 6f9de94 Compare October 5, 2020 10:34
@Nir-Az Nir-Az requested a review from ev-mp October 5, 2020 10:34
ev-mp
ev-mp approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit 1ef7b3a into IntelRealSense:development Oct 5, 2020
@Nir-Az Nir-Az deleted the add_hum_sensor_to_viewer branch April 8, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nir-Az @ev-mp